Re: [PATCH] 2.5.27 smbiod

[Albert D. Cahalan]

Marcin Dalecki writes:

> Fix label at block end warning - don't write "assembler code".
...
>  	if (server->state != CONN_VALID)
> -		goto out;
> +		return;
...
> -
> -out:
>  }

Assembler? No, that would be Pascal. Many would argue
that a return out of the middle is as ugly as a goto.

Maybe it doesn't matter, and maybe you did actually
improve the code generation, but there's an obvious
way to ditch the warning without changing so much.
Note the semicolon:

out:;
}