Re: [2.5 patch] make de2104x hotplugable

[Jeff Garzik]

Adrian Bunk wrote:
> Hi Jeff,
> 
> since drivers/net/tulip/de2104x.c does currently not compile in 2.5.29 due
> to a .text.exit error when the driver is compiled into a kernel without
> hotplug support I'm wondering whether the patch below would be correct to
> make this PCI driver hotpluggable. Is my approach to change __init to
> __devinit and __exit to __devexit correct or is there something I've
> overseen?

This driver is intentionally not hot-pluggable.  I'll convert when 
someone actually tells me they are trying to hot-plug such a card.

> -static int __init de_init (void)
> +static int __devinit de_init (void)
>  {
>  #ifdef MODULE
>  	printk("%s", version);
> @@ -2231,7 +2231,7 @@
>  	return pci_module_init (&de_driver);
>  }
> 
> -static void __exit de_exit (void)
> +static void __devexit de_exit (void)
>  {
>  	pci_unregister_driver (&de_driver);
>  }

This is incorrect in any case -- the module init/exit functions are 
always __init and __exit.

	Jeff