Please don't make this depenend on S_ISBLK(). There are filesystems (like
XFS) that are designed to safely allow concurrent O_DIRECT writes to
Toe implement this properly we should drop i_sem in the ->direct_IO method
of the filesystem/blockdevice. The only question remaining is whether the
method has to reqacquire it before returing (and it'll be imediately
released again or whether we should change semantics of ->direct_IO to
always drop the lock.
The third options would be to never call ->direct_IO with the i_sem held
and let filesystems that need it (only ext2 in 2.5 mainline) do
I think I prefer option 3, it's the cleanest way of doing it.
A little unrelated, but as you touch the code: what about removing the two
existing special cases for S_ISBLK() in generic_file_write()? they're
present only to provide the old (pre-LFS) blockdevice semantics on 2.4,
we shouldn't keept them around forever..
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to firstname.lastname@example.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/