Re: [PATCH] vfs_read/vfs_write small bug fix (2.5.29)

[Paul Larson]

On Mon, 2002-07-29 at 13:25, Badari Pulavarty wrote:
> Hi,
> 
> Here is a patch to fix small bug in for vfs_read/vfs_write.
> 
> Please apply.
This is actually one of the same issues I was looking at this morning. 
I noticed that the Linux Test Project tests pread02 and pwrite02 were
failing because of this.  However I also had to do some typecasting to
make it work correctly.  I'm not sure this is the best way to do it, but
without the typecasting, the tests still fail.

-Paul Larson

diff -Nru a/fs/read_write.c b/fs/read_write.c
--- a/fs/read_write.c	Mon Jul 29 14:48:45 2002
+++ b/fs/read_write.c	Mon Jul 29 14:48:45 2002
@@ -185,7 +185,7 @@
 		return -EBADF;
 	if (!file->f_op || !file->f_op->read)
 		return -EINVAL;
-	if (pos < 0)
+	if ((int)*pos < 0)
 		return -EINVAL;
 
 	ret = locks_verify_area(FLOCK_VERIFY_READ, inode, file, *pos, count);
@@ -210,7 +210,7 @@
 		return -EBADF;
 	if (!file->f_op || !file->f_op->write)
 		return -EINVAL;
-	if (pos < 0)
+	if ((int)*pos < 0)
 		return -EINVAL;
 
 	ret = locks_verify_area(FLOCK_VERIFY_WRITE, inode, file, *pos, count);