Re: 2.4.19, USB_HID only works compiled in, not as module

[Brad Hards]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 6 Aug 2002 02:56, Greg KH wrote:
> On Tue, Aug 06, 2002 at 12:00:55AM +1000, Brad Hards wrote:
> > Greg: I think this was one of your patches, associated with the
> > HIDINPUT patch. It looks like the return value is wrong. See
> > below.
> >
> > --- include/linux/hiddev.h.orig Mon Aug  5 23:19:54 2002
> > +++ include/linux/hiddev.h      Mon Aug  5 23:56:34 2002
> > @@ -183,7 +183,7 @@
> >  int __init hiddev_init(void);
> >  void __exit hiddev_exit(void);
> >  #else
> > -static inline void *hiddev_connect(struct hid_device *hid) { return
> > NULL; } +static inline void *hiddev_connect(struct hid_device *hid) {
> > return -1; } static inline void hiddev_disconnect(struct hid_device *hid)
> > { } static inline void hiddev_hid_event(struct hid_device *hid, unsigned
> > int usage, int value) { } static inline int hiddev_init(void) { return 0;
> > }
>
> ??? Why return -1 as a void *?
>
> The only caller of hiddev_connect is:
> 	if (!hiddev_connect(hid))
> 		hid->claimed |= HID_CLAIMED_HIDDEV;
>
> Hm, seems like you don't want a void * there at all, but a int, right?
I assume so.

> But that doesn't explain the error people are having with the code
> compiled in.
No - while doing the investigation, I noted that dmesg was showing
input0,hiddev0: USB HID v1.10 Keyboard [045e:001d] on usb2:3.0
input1,hiddev0: USB HID v1.10 Pointer [045e:001d] on usb2:3.1
input2,hiddev0: USB HID v1.00 Mouse [Logitech USB-PS/2 Mouse M-BA47] on usb2:4.0

with CONFIG_USB_HIDDEV turned off.

So I chased that down to the above conclusion.

But I still don't see the problem, and can't duplicate it.

Brad
- -- 
http://conf.linux.org.au. 22-25Jan2003. Perth, Australia. Birds in Black.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9TufiW6pHgIdAuOMRAojFAKCmSOjjTwcp6z7tPKeR6kaokAF71wCginFW
5/94epXIyAJlfpFGtmQqxOY=
=Ywrd
-----END PGP SIGNATURE-----