Re: [patch] clone_startup(), 2.5.31-A0

Linus Torvalds (torvalds@transmeta.com)
Tue, 13 Aug 2002 08:30:24 -0700 (PDT)


On Tue, 13 Aug 2002, Ingo Molnar wrote:
>
> the attached patch implements a new syscall on x86, clone_startup().

Hmm.

Please don't do that CLONE_STARTUP flag thing. Just do the code inside the
sys_clone_startup(), instead of dynamically adding a new flag. And that
code looks like it returns EFAULT without freeing the stuff it has
allocated.

Also, "caching" &tsk->thread only adds code - even if it makes the sources
slightly shorter. It adds a register that is just a constant offset from
another register.

Other than that the thing seems to make sense.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/