Re: [PATCH][RFC] sigurg/sigio cleanup for 2.5.31

James Morris (jmorris@intercode.com.au)
Sat, 17 Aug 2002 01:03:20 +1000 (EST)


On Fri, 16 Aug 2002 kuznet@ms2.inr.ac.ru wrote:

> Hello!
>
> > All existing paths which write to the pid/uid/euid fields are protected by
> > the BKL
>
> euid? Are you about current->xxx? You jest, you read it, not write.
>

I'm talking about writing f_owner fields, i.e:

filp->f_owner.pid = current->pid;
filp->f_owner.uid = current->uid;
filp->f_owner.euid = current->euid;

> Ergo, never use BKL. :-)

Well, do you think it's worth adding a spinlock for just one fcntl handler
and the SIOCSPGRP/FIOSETOWN ioctls?

- James

-- 
James Morris
<jmorris@intercode.com.au>

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/