Re: Kernel.Org bug in viewing of patches

H. Peter Anvin (hpa@zytor.com)
19 Aug 2002 10:18:37 -0700


Followup to: <3D60842D.7030406@genebrew.com>
By author: Rahul Karnik <rahul@genebrew.com>
In newsgroup: linux.dev.kernel
>
> Kernel.Org admins,
>
> I was using the nifty patch viewing feature on the homepage when I
> noticed that in the per-file patch list for a given patch, the links
> generated are not correct. An example is the current ac patch view at:
>
> http://www.kernel.org/diff/diffview.cgi?file=/pub/linux/kernel/people/alan/linux-2.4/2.4.20/patch-2.4.20-pre2-ac4.gz
>
> Clicking on the link for drivers/net/3c59x.c actually leads to the patch
> for drivers/net/cs89x0.h. Similar problems appear to exist for viewing
> of the other patches as well, with different offsets in the file list.
>

The problem seems to be with diffstat, which occationally drops hunks
-- resulting in the count being incorrect.

-hpa

-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<amsp@zytor.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/