Re: Patch for PC keyboard driver's autorepeat-rate handling

Alan Cox (alan@lxorguk.ukuu.org.uk)
22 Aug 2002 18:31:02 +0100


On Thu, 2002-08-22 at 16:59, Alan Stern wrote:
> properly? The error is not in the program; it's in the kernel's
> handling of the KDKBDREP ioctl. This patch fixes the following three
> mistakes:
>
> The .rate member of struct kbd_repeat is actually a repeat
> _period_ measured in msec; the driver interprets it as a
> repeat _rate_ in characters per second.
>
> The driver returns the _prior_ values of the rate and delay
> settings rather than the _current_ values.
>
> The driver looks for an exact match for the rate and delay
> values rather than using the closest match.

Since its done what it does now since about 1991, it would be better to
fix the documentation if in fact there is an error.

> Incidentally, does anybody know why drivers/char/pc_keyb.c hasn't been
> moved to the arch/i386 part of the directory tree?

"PC" keyboard and PS/2 mouse hardware can appear on almost any system,
even on plug in PCI cards.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/