Re: [BK PATCH] USB changes for 2.5.34

[Matthew Dharm]

--xJK8B5Wah2CMJs8h
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Linus, normally I would agree with you on this, but...

(1) We can't always handle it.  The current code implements a heuristic,
which is not always correct.  When it gets it wrong....

(2) show_trace() was proving ineffective in bringing the bad commands to
light so they might be fixed

(3) Given that we think we've fixed all of these bad initiators, the BUG()
really is something that should never happen.

Matt

On Mon, Sep 09, 2002 at 05:17:40PM -0700, Linus Torvalds wrote:
>=20
> Greg, please don't do this
>=20
> > ChangeSet@1.614, 2002-09-05 08:33:20-07:00, [e-mail]
> >   USB: storage driver: replace show_trace() with BUG()
>=20
> that BUG() thing is _way_ out of line, and has killed a few of my machine=
s=20
> several times for no good reason. It actively hurts debuggability, becaus=
e=20
> the machine is totally dead after it, and the whole and ONLY point of=20
> BUG() messages is to help debugging and make it clear that we can't handl=
e=20
> something.
>=20
> In this case, we _can_ handle it, and we're much better off with a machin=
e=20
> that works and that you can look up the messages with than killing it.
>=20
> Rule of thumb: BUG() is only good for something that never happens and=20
> that we really have no other option for (ie state is so corrupt that=20
> continuing is deadly).
>=20
> 		Linus
>=20
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [e-mail]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--=20
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.=
net=20
Maintainer, Linux USB Mass Storage Driver

I need a computer?
					-- Customer
User Friendly, 2/19/1998

--xJK8B5Wah2CMJs8h
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9fVPNIjReC7bSPZARAilVAKCXVEmeYSYYN7NEZl1aECHTCgEz4QCdFf5V
kXOCp2Jzw0JGJUAlsU5iaTc=
=XhvW
-----END PGP SIGNATURE-----

--xJK8B5Wah2CMJs8h--