Re: [PATCH] 2.5.34 ufs/super.c

[Skip Ford]

Zwane Mwaikambo wrote:
> On Mon, 9 Sep 2002, Skip Ford wrote:
> 
> > I've needed this patch since 2.5.32 to successfully mount a UFS
> > partition.
> > 
> > --- linux/fs/ufs/super.c~	Mon Sep  9 16:39:52 2002
> > +++ linux/fs/ufs/super.c	Mon Sep  9 16:39:57 2002
> > @@ -605,7 +605,7 @@
> >  	}
> >  	
> >  again:	
> > -	if (sb_set_blocksize(sb, block_size)) {
> > +	if (!sb_set_blocksize(sb, block_size)) {
> >  		printk(KERN_ERR "UFS: failed to set blocksize\n");
> >  		goto failed;
> >  	}
> 
> Good heavens! I introduced that bug when fixing another bug a while ago, i 
> was pretty certain it got fixed (it got fixed in 2.4 and -dj(?))

Here's the snippet from patch-2.5.32 that did it.  This just went in a
week or two ago.

-	sb_set_blocksize(sb, block_size);
+	if (sb_set_blocksize(sb, block_size)) {
+		printk(KERN_ERR "UFS: failed to set blocksize\n");
+		goto failed;
+	}

-- 
Skip