Re: [patch 9/9]Four new i2c drivers and __init/__exit cleanup to

Jeff Garzik (jgarzik@mandrakesoft.com)
Sun, 15 Sep 2002 19:18:46 -0400


Albert Cranford wrote:
> --- linux/drivers/i2c/i2c-elektor.c.orig 2002-09-14 22:10:45.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-elektor.c 2002-09-15 01:18:55.000000000 -0400
> @@ -125,12 +125,12 @@
> int timeout = 2;
>
> if (irq > 0) {
> - cli();
> + local_irq_disable();
> if (pcf_pending == 0) {
> interruptible_sleep_on_timeout(&pcf_wait, timeout*HZ );
> } else
> pcf_pending = 0;
> - sti();
> + local_irq_enable();
> } else {
> udelay(100);
> }

this is _not_ the way to fix... use a proper spinlock

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/