Re: [patch] generic-pidhash-2.5.36-J2, BK-curr

Ingo Molnar (mingo@elte.hu)
Thu, 19 Sep 2002 23:39:36 +0200 (CEST)


On Thu, 19 Sep 2002, Linus Torvalds wrote:

> I'm also applying the session handling changes to tty_io.c as a separate
> changeset, since the resulting code is certainly cleaner and reading
> peoples areguments and looking at the code have made me think it _is_
> correct after all.

yes, i too think it's correct. In fact this is partly proven by one piece
of code in the old tty_io.c file:

void disassociate_ctty(int on_exit)
[...]
read_lock(&tasklist_lock);
for_each_process(p)
if (p->session == current->session)
p->tty = NULL;
read_unlock(&tasklist_lock);

ie. if the SID-based iteration is incorrect, then the above code is
incorrect already - but we never saw any problems in this area.

Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/