> [snip config bits]
> OTOH I wonder whether you really want an submenu. It could as well just
> be part of the general settings one.
I was a bit dubious it might be hard to find. It's not particularly
> Usually <foo>-objs is below obj-*, but that's just cosmetic. The Makefile
> inclusion seems very wrong to me. Why do you need it?
It's by far the simplest way to build the single module target...
> Shouldn't drivers/oprofile/i386/ be arch/i386/oprofile??
Perhaps. I kind of liked the code to be together. Also I wasn't sure how
I could convince kbuild to make a single target from the disparate dirs.
Kai mentioned that XFS does something similar, I'll look into that ...
> Why is this copyright different from the others?
Perils of very similar vim iab's ... fixed
> Why don't you just set no write method at all?
> Maybe oprofilefs wants to become a generic version, it has nothing
I don't know what you mean here. Do you mean hooking into driverfs ?
Last I checked it wasn't suitable for such oddball minifs's.
> Please use cond_syscall() and compile that file only for CONFIG_PROFILING set.
> + struct dcookie_struct * d_cookie; /* cookie, if any */
> Make that conditional on CONFIG_PROFILING?
And same for the task_struct field. Will do.
> Put that exports into profile.c?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to email@example.com
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/