Re: [PATCH-RFC] README 1ST - New problem logging macros (2.5.38)

Patrick Mochel (mochel@osdl.org)
Tue, 24 Sep 2002 09:32:10 -0700 (PDT)


On Mon, 23 Sep 2002, Greg KH wrote:

> One further comment:
>
> On Mon, Sep 23, 2002 at 06:55:13PM -0700, Larry Kessler wrote:
> > --- linux-2.5.37/drivers/include/linux/net_problem.h Wed Dec 31 18:00:00 1969
> > +++ linux-2.5.37-net/include/linux/net_problem.h Mon Sep 23 20:04:23 2002
>
>
> > --- linux-2.5.37/drivers/include/linux/pci_problem.h Wed Dec 31 18:00:00 1969
> > +++ linux-2.5.37-net/include/linux/pci_problem.h Mon Sep 23 19:56:11 2002
>
> {sigh}
>
> Have people been ignoring all of the core driver changes that have been
> happening? Almost everything that is "struct device" now, with some bus
> specific things tacked on (and those bus specific things are getting
> slowly merged into struct device too.)
>
> It would make more sense (if you continue this path of changes to the
> kernel) to focus on the device, bus, and class structures. That way you
> don't have to create a usb_problem.h, iee1394_problem.h, i2c_problem.h,
> i2o_problem.h, scsi_problem.h, ide_problem.h, etc.

On a tangent and ignoring the completely correct statement...

Why do we have such a flat namespace in include/linux/ anyway? Assuming
introducing a problem.h header for each subsystem was a sound idea, we
could just have

include/linux/problem/pci.h
include/linux/problem/net.h
...

-pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/