Re: [PATCH] fix ide-iops for big endian archs

Richard Zidlicky (rz@linux-m68k.org)
Thu, 26 Sep 2002 22:58:47 +0200


On Thu, Sep 26, 2002 at 05:14:14PM +0200, Benjamin Herrenschmidt wrote:
> >On Wed, 2002-09-25 at 13:32, Benjamin Herrenschmidt wrote:
> >> I enclosed the patch as an attachement too in case the mailer screws
> >> it up...
> >
> >Please do one thing. For the stuff that needs weird powerpcisms put all
> >the seperate stuff in one block with its own copy of the static inlines
> >so we dont have in ifdef in half the functions in the file
>
> This is _NOT_ a weird PowerPC'ism !!!
>
> It's just a matter of use the proper operation, that is "insw/outsw"
> instead of trying to re-implement it with a loop of basic inw/outw,
> which is wrong for _any_ BE arch (except maybe weird m68k'ism where
> IDE is wired the wrong way around)

to put it a bit more precise, this is bus endianness, nothing to
do with arch endianness.

Richard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/