Re: [PATCH] Put modules into linear mapping

[Andi Kleen]

Roman Zippel <[e-mail]> writes:

> Why is i386 only? This is generic code and other archs will benefit from
> it as well (or at least it won't hurt).

Because some arcitectures have a different module_map() (e.g. x86-64 or 
sparc64) and because the VMALLOC_START/END trick doesn't work on all.

> > +
> > +void *alloc_exact(unsigned int size)
> > +{
> > +	struct page *p, *w;
> > +	int order = get_order(size);
> > +
> > +	p = alloc_pages(GFP_KERNEL, order);
> 
> Wouldn't it be better to add a gfp argument?

I don't see a need for it. GFP_ATOMIC doesn't make sense for > order 0,
and > order 0 is the only case that is interesting for alloc_exact. 
GFP_DMA is not needed here, and GFP_HIGHUSER neither supports > order 0 
properly (because of kmap) 

-Andi