Re: a bug in 8250.c

Russell King (rmk@arm.linux.org.uk)
Sun, 29 Sep 2002 09:17:47 +0100

On Sun, Sep 29, 2002 at 10:15:23AM +0800, Hu Gang wrote:
> In serial8250_request_std_resource@825.c, if all is pass it return 0, or failed return -XX, But you use
> ret = serial8250_request_std_resource(up, &res_std);
> -> if (ret)
> return;
> I'm guess it use as .
> -> if (ret == 0)

This is very wrong.

If we claim the resource, we fail in this function. If we don't claim,
we succeed.

> After change code, 2.5.39 Can found my modem.

I guess you've got a resource clash. Can you remove this patch from your
system, and then send the kernel boot messages, and the contents of
/proc/iomem and /proc/ioports please.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/