Re: [PATCH] Re: Capabilities-related change in 2.5.40

Chris Wright (chris@wirex.com)
Wed, 2 Oct 2002 09:25:19 -0700


* Daniel Jacobowitz (dan@debian.org) wrote:
>
> Look at cap_proc.c:_libcap_cappid :

Right, but cap_get_proc calls _libcap_cappid with pid of 0. At any
rate, I believe pid == 0 is intentional to pick up the current
capabilities.

> How very odd. I have been running 2.5 on that machine for a while, and
> the bug only showed up somewhere between 2.5.36 and 2.5.40. Maybe a
> coincidence triggered by the PID hashing... your tabbing is a little
> odd but the patch looks right to me. Thanks!

I tried on various older 2.5 kernels (> 2.5.20) and they returned -ESRCH.
I agree, the PID hashing probably started picking up swapper. And yes
the tabbing is odd. The file is badly in need of Lindent, as it's mostly
space tabbed. I didn't want to hide the patch in whitespace changes ;-)

thanks,
-chris

-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/