Re: [PATCH] Start of cleaning up socket ioctls

Alan Cox (alan@lxorguk.ukuu.org.uk)
03 Oct 2002 16:23:19 +0100


On Thu, 2002-10-03 at 15:52, Matthew Wilcox wrote:
>
> All the ioctls are passed to the socket's ioctl methods, even when they're
> utterly generic. Here's a patch which starts to move the really generic
> ones up to the top level. As you can see, this eliminates a huge amount
> of code duplication.

Nice but one request - can you call the protocol handlers first and if
they return -ENOTTY then call the default ones provided by the upper
layer. That will let you remove even more common code to most versions,
make it work like the serial and other layers do, and still let people
override defaults

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/