Re: [PATCH] add safe version of list_for_each_entry() to list.h

Christoph Hellwig (hch@infradead.org)
Fri, 4 Oct 2002 14:58:50 +0100


> =========================================================
> diff -Naur linux-2.5.40a/include/linux/list.h linux-2.5.40b/include/linux/list.h
> --- linux-2.5.40a/include/linux/list.h Tue Oct 1 02:05:48 2002
> +++ linux-2.5.40b/include/linux/list.h Thu Oct 3 19:17:27 2002
> @@ -137,6 +137,15 @@
> return head->next == head;
> }
>
> +/**
> + * list_member - tests whether a list member is currently on a list
> + * @member: member to evaulate
> + */
> +static inline int list_member(struct list_head *member)
> +{
> + return ((!member->next || !member->prev) ? 0 : 1);

Wouldn't return (member->next && member->prev); be simpler?

> + */
> +#define list_for_each_entry_safe(pos, n, head, member) \
> + for (pos = list_entry((head)->next, typeof(*pos), member), \
> + n = list_entry(pos->member.next, typeof(*pos), member); \
> + &pos->member != (head); \
> + pos = n, \
> + n = list_entry(pos->member.next, typeof(*pos), member))
>

Identation looks a little strange..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/