Re: [PATCH] add safe version of list_for_each_entry() to list.h

Kevin Corry (corryk@us.ibm.com)
Fri, 4 Oct 2002 08:48:52 -0500


On Friday 04 October 2002 08:58, Christoph Hellwig wrote:
> > +/**
> > + * list_member - tests whether a list member is currently on a list
> > + * @member: member to evaulate
> > + */
> > +static inline int list_member(struct list_head *member)
> > +{
> > + return ((!member->next || !member->prev) ? 0 : 1);
>
> Wouldn't return (member->next && member->prev); be simpler?

Sure. New patch below with new list_member() function.

> > + */
> > +#define list_for_each_entry_safe(pos, n, head, member) \
> > + for (pos = list_entry((head)->next, typeof(*pos), member), \
> > + n = list_entry(pos->member.next, typeof(*pos), member); \
> > + &pos->member != (head); \
> > + pos = n, \
> > + n = list_entry(pos->member.next, typeof(*pos), member))
>
> Identation looks a little strange..

Perhaps. But there are plenty of places in list.h that have some strange
indenting. If you'd like it another way, please post a patch with your
preferred version.

-- 
Kevin Corry
corryk@us.ibm.com
http://evms.sourceforge.net/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/