Re: [BK PATCH] minor devfs cleanup for 2.5.40

Richard Gooch (rgooch@ras.ucalgary.ca)
Fri, 4 Oct 2002 10:17:34 -0600


Greg KH writes:
> Here's a changeset from Christoph Hellwig that removes some unneeded
> code from the kernel core. This was leftover from before devfs became
> part of the main kernel tree, and was trying to do some naming fixups in
> kernelspace. If anyone still has machines using these names, their
> startup scripts should be modified to use the "standard" devfs names.
>
> Please pull from: http://linuxusb.bkbits.net/devfs-2.5

NO! Dammit, you'll break everyone who is using these compact names to
mount the root FS. Look more closely at the code you're trying to
remove, and you'll see it's *not* used to avoid work in startup
scripts. It's only used to create the devfs entry for the root FS.

This change is gratuitous. The code is __init code anyway, so doesn't
contribute to bloat. And forcing people to migrate to the longer names
isn't reasonable, as it chews up precious space on the kernel command
line. I've had times where I ran out of space when I had too many
options.

Linus, please don't apply.

Regards,

Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/