Re: [BK PATCH] pcibios_* removals for 2.5.40

Jeff Garzik (jgarzik@pobox.com)
Fri, 04 Oct 2002 17:34:40 -0400


Greg KH wrote:
> @@ -1563,13 +1562,11 @@
>
> if (pci_present()) {

an example of pci_present() that can be eliminated, as I described earlier

> for (i = 0; i < NPCI_CHIP_IDS; ++i)
> - for (pci_index = 0;
> - !pcibios_find_device (PCI_VENDOR_ID_NCR,
> - pci_chip_ids[i].pci_device_id, pci_index, &pci_bus,
> - &pci_device_fn);
> - ++pci_index)
> + while ((pdev = pci_find_device (PCI_VENDOR_ID_NCR,
> + pci_chip_ids[i].pci_device_id,
> + pdev)))
> if (!ncr_pci_init (tpnt, BOARD_GENERIC, pci_chip_ids[i].chip,
> - pci_bus, pci_device_fn, /* no options */ 0))
> + pdev->bus->number, pdev->devfn, /* no options */ 0))

can you eliminate the need of ncr_pci_init to have number/devfn args?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/