Re: [RFC] bridge-nf -- map IPv4 hooks onto bridge hooks, vs 2.5.42

David S. Miller (davem@redhat.com)
Mon, 14 Oct 2002 11:01:59 -0700 (PDT)


These changes cannot go in:

1) There is no reason the 'okfn' you use cannot be the
function doing the MAC header copy.

This is how this is supposed to work.

I explained in that long thread a few weeks ago how
this copy may not be placed in the generic IP code.
This is final, you must find a way to make this copy
without touching ipv4/*.c

2) The netfilter changes need to be approved by the netfilter
team.

I suspect, like myself, they will barf at the phys{in,out}dev
additions to sk_buff. We already have enough junk sitting
in sk_buff making it larger than it needs to be.

Perhaps you can hang this off the nf_conntrack pointer and
specify a destructor.

3) The bridging layer changes need to be approved by Lennert.
But I'd suggest working out #1 and #2 first.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/