Re: [PATCH 1/4] Add extended attributes to ext2/3

[Andreas Dilger]

On Oct 14, 2002  21:46 -0700, Andrew Morton wrote:
> btw, gcc-2.91.66 is saying:
> 
> fs/ext2/xattr.c: In function `ext2_xattr_set':
> fs/ext2/xattr.c:612: warning: `block' might be used uninitialized in this function
> 
> But the code is:
> 
>                 int block = EXT2_I(inode)->i_file_acl;
> 
> which is rather bizarre.  Never seen it do that before.

There's a "goto bad_block" in that function, and it enters _after_
block is set (block is a local variable), so it is impossible for
it to have a valid value.

Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/