Re: unhappy with current.h

[Mikael Pettersson]

Rik van Riel writes:
 > On Mon, 14 Oct 2002, Chris Wedgwood wrote:
 > > On Mon, Oct 14, 2002 at 09:46:08PM +0200, Daniele Lugli wrote:
 > >
 > > > I recently wrote a kernel module which gave me some mysterious
 > > > problems. After too many days spent in blood, sweat and tears, I found the cause:
 > >
 > > > *** one of my data structures has a field named 'current'. ***
 > >
 > > gcc -Wshadow
 > 
 > Would it be a good idea to add -Wshadow to the kernel
 > compile options by default ?

While I'm not defending macro abuse, please note that Daniele's problem
appears to have been caused by using g++ instead of gcc or gcc -x c to
compile a kernel module. Daniele's later example throws a syntax error
in gcc, since the cpp output isn't legal C ...

Hence I fail to see the utility of hacking in kludges for something
that's not supposed to work anyway.