Re: [PATCH 2/3] Add extended attributes to ext2/3

Henning P. Schmiedehausen (hps@intermeta.de)
Wed, 16 Oct 2002 09:38:02 +0000 (UTC)

tytso@mit.edu writes:

>+ int ea_blocks = EXT3_I(inode)->i_file_acl ?
>+ (inode->i_sb->s_blocksize >> 9) : 0;

Sometimes I wonder if we shouldn't have the block size (512) and the
bit shift (9) as defines somewhere and gradually shift away from hard
coded values...

If we ever decide to change the block size of ext2/ext3, we're in for
a "looking for nines"... :-)

Regards
Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen       -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH     hps@intermeta.de


Am Schwabachgrund 22  Fon.: 09131 / 50654-0   info@intermeta.de
D-91054 Buckenhof     Fax.: 09131 / 50654-20   
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/