Re: XFS build error on m68k in 2.5.43

[Keith Owens]

On Wed, 16 Oct 2002 13:21:39 +0200 (MEST), 
Geert Uytterhoeven <[e-mail]> wrote:
>
>When compiling a kernel for m68k (with CONFIG_XFS_FS=m), I get this error:
>
>| make -f fs/xfs/Makefile 
>|    rm -f fs/xfs/built-in.o; m68k-linux-ar rcs fs/xfs/built-in.o
>|   m68k-linux-gcc -Wp,-MD,fs/xfs/linux/.xfs_stats.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -fno-strength-reduce -ffixed-a2 -nostdinc -iwithprefix include -DMODULE -Ifs/xfs -funsigned-char  -DKBUILD_BASENAME=xfs_stats   -c -o fs/xfs/linux/xfs_stats.o fs/xfs/linux/xfs_stats.c
>| In file included from fs/xfs/xfs.h:70,
>|                  from fs/xfs/linux/xfs_stats.c:33:
>| fs/xfs/xfs_bmap_btree.h:662: badly punctuated parameter list in `#define'
>| fs/xfs/xfs_log.h:62: warning: `_lsn_cmp' defined but not used
>| make[2]: *** [fs/xfs/linux/xfs_stats.o] Error 1
>| make[1]: *** [fs/xfs] Error 2
>| make: *** [fs] Error 2
>
>Since it's not obvious to me what's wrong with that define, I'm asking here.

Spot the typo :(

--- fs/xfs/xfs_bmap_btree.h.orig	Wed Oct 16 21:28:36 2002
+++ fs/xfs/xfs_bmap_btree.h	Wed Oct 16 21:28:49 2002
@@ -658,8 +658,8 @@
 #else
 #define xfs_bmbt_disk_set_all(r, s) \
 	xfs_bmbt_set_all(r, s)
-#define xfs_bmbt_disk_set_allf(r, 0, b, c, v) \
-	xfs_bmbt_set_allf(r, 0, b, c, v)
+#define xfs_bmbt_disk_set_allf(r, o, b, c, v) \
+	xfs_bmbt_set_allf(r, o, b, c, v)
 #endif
 
 void