Re: [PATCH 2/3] Add extended attributes to ext2/3

[Lorenzo Allegrucci]

On Wednesday 16 October 2002 18:16, Theodore Ts'o wrote:
> On Wed, Oct 16, 2002 at 09:38:02AM +0000, Henning P. Schmiedehausen wrote:
> > [e-mail] writes:
> > >+	int ea_blocks = EXT3_I(inode)->i_file_acl ?
> > >+		(inode->i_sb->s_blocksize >> 9) : 0;
> >
> > Sometimes I wonder if we shouldn't have the block size (512) and the
> > bit shift (9) as defines somewhere and gradually shift away from hard
> > coded values...
> >
> > If we ever decide to change the block size of ext2/ext3, we're in for
> > a "looking for nines"... :-)
>
> We already have different block sizes for ext2/3; we support 1k, 2k,
> and 4k block sizes.

BTW, why doesn't ext2/3 support 512 byte block sizes?