Re: [PATCH] ipv4: make arp seq_file show method only produce one

Neil Brown (neilb@cse.unsw.edu.au)
Thu, 17 Oct 2002 11:30:43 +1000


On Wednesday October 16, davem@redhat.com wrote:
> From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
> Date: Wed, 16 Oct 2002 22:11:08 -0300
>
> That would be nice, yes, bastardizing pos for this is, humm, ugly, and
> it isn't accessible at show time (pun intended 8) ).
>
> Can you remind me what the original objection was to
> just using seq->private? Is it used, or planned to
> be used, by something else?

I use seq->private for private state for /proc/fs/nfs/exports.
It works nicely.
You need to define an 'open' the sets it up, and a 'release' to
tear it down, rather than doing it in start/stop.
See fs/nfsd/fnsctl.c:exports_open

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/