Re: [PATCHSET] Mobile IPv6 for 2.5.43

(no name) ((no email))
Fri, 18 Oct 2002 02:18:02 +0900 (JST)


In article <20021017162624.GC16370@morphine.tml.hut.fi> (at Thu, 17 Oct 2002 19:26:25 +0300), Antti Tuominen <ajtuomin@morphine.tml.hut.fi> says:

> The patch has been split for easier reading as follows:
>
> ipv6_tunnel.patch 6over6 tunneling
> network_mods.patch Modifications to network code and hooks

Several comments.

[ipv6_tunnel]

I think this is almost ok.

1. I believe s/ARPHRD_IPV6_IPV6_TUNNEL/ARPHRD_TUNNEL6/.
2. Please put outer address to hardware address in dev.
Note: you need to modify SIOxxx ioctls too not to overrun!

[network_mods etc.]

1. Too many hooks,
and many duplicate codes in ipv6 stack and mipv6 stack.
(prefix handler, header parser, ndisc handler etc...)

more comment will come later...

> http://www.mipl.mediapoli.com/patches/mipv6_cn_support.patch
> http://www.mipl.mediapoli.com/patches/mipv6_mn_support.patch
> http://www.mipl.mediapoli.com/patches/mipv6_ha_support.patch

Well, I can't find them. I hope they'll be available when I wake up
tomorrow...

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/