Re: [PATCH] GART driver support for generic AGP 3.0 device detection/ enabling & Intel 7505 chipset support

[Greg KH]

On Thu, Oct 17, 2002 at 11:13:19AM -0700, Tolentino, Matthew E wrote:
> Attached is a patch for generic AGP 3.0 device detection and enabling
> routines as well as specific support for the Intel 7505 chipset against the
> 2.5.43 kernel.   

Just a minor comment:

diff -urN linux-2.5.43-vanilla/drivers/char/agp/Makefile linux-2.5.43/drivers/char/agp/Makefile
--- linux-2.5.43-vanilla/drivers/char/agp/Makefile	Tue Oct 15 20:27:49 2002
+++ linux-2.5.43/drivers/char/agp/Makefile	Thu Oct 17 10:12:41 2002
@@ -3,12 +3,13 @@
 # space ioctl interface to use agp memory.  It also adds a kernel interface
 # that other drivers could use to manipulate agp memory.
 
-export-objs := agp.o
+export-objs := agp.o agp3.o
 
-agpgart-y := agp.o frontend.o
+agpgart-y := agp.o agp3.o frontend.o 
 
 agpgart-$(CONFIG_AGP_INTEL)	+= i8x0-agp.o
 agpgart-$(CONFIG_AGP_I810)	+= i810-agp.o
+agpgart-$(CONFIG_AGP_I7505)	+= i7505-agp.o
 agpgart-$(CONFIG_AGP_VIA)	+= via-agp.o
 agpgart-$(CONFIG_AGP_AMD)	+= amd-agp.o
 agpgart-$(CONFIG_AGP_SIS)	+= sis-agp.o

You should probably not build agp3.o unless i7505-agp.o is built too, or
do some of the other drivers need functions in agp3.c?

thanks,

greg k-h