Re: [PATCH][RFC] add support for PC-9800 architecture (20/26) serial #1

Andrey Panin (pazke@orbita1.ru)
Fri, 18 Oct 2002 10:06:11 +0400


--Fba/0zbH8Xs+Fj9o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 17, 2002 at 03:11:25PM +0100, Russell King wrote:
> I strongly recommend _n_o_t_ merging this patch.

Did you see the next patch (21/26 serial #2) ? It looks even more interesti=
ng.
As I understand serial98.c driver should support older i8251 UART.
However it does it by perverting 8250.c and EMULATING i8250 on top of i8251,
see ugly code in serial_in() and serial_out() functions.

May be I misunderstand the issue, but IMHO this patch is unacceptible too :(

Best regards.
=20
--=20
Andrey Panin | Embedded systems software developer
pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net

--Fba/0zbH8Xs+Fj9o
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9r6TTBm4rlNOo3YgRAiZUAJ9sF74gW11oZOqGTyX/7yyM8DemCwCfXbFb
vJY83kn6D/olOLoDq2VJVh8=
=LsaK
-----END PGP SIGNATURE-----

--Fba/0zbH8Xs+Fj9o--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/