Re: [BK PATCHS] fbdev updates.

[James Simmons]

> So the generic part of the code should behave like this:
>
>   if (info->fbops->fb_blank && info->fbops->fb_blank(blank_flag)) {
>       /* use hardware blanking */
>   } else if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR ||
> 	     info->fix.visual == FB_VISUAL_DIRECTCOLOR) {
>       /* use software blanking */
>   } else {
>       /* no blanking possible, except for filling the screen with black, which
> 	 is not appropriate (unless we save/restore the contents?) */
>   }
>
> Is that OK for you?

I was thinking more like

   if (info->fbops->fb_blank && info->fbops->fb_blank(blank_flag)) {
       /* use hardware blanking */
   } else if (info->var.accel_flags) {
	/* Use hardware fillrect to blank the screen */
 	info->fbops->fb_fillrect(info, whole_screen);
   } else {
	/* Nothing avaiable. Use set the colormap to black */
   }

What do you think?