Re: Linux v2.5.43

[Adrian Bunk]

On Tue, 15 Oct 2002, Linus Torvalds wrote:

>...
> Summary of changes from v2.5.42 to v2.5.43
> ============================================
>...
> Ben Collins <[e-mail]>:
>   o Linux IEEE-1394 Updates
>...

This patch added an argument "flags" to the prototypes of
sbp2_handle_physdma_write and sbp2_handle_physdma_read in
drivers/ieee1394/sbp2.h but doesn't include the corresponding changes to
drivers/ieee1394/sbp2.c resulting in the following compile error:

<--  snip  -->

...
  gcc -Wp,-MD,drivers/ieee1394/.sbp2.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -Iarch/i386/mach-generic
-nostdinc -iwithprefix include    -DKBUILD_BASENAME=sbp2   -c -o
drivers/ieee1394/sbp2.o drivers/ieee1394/sbp2.c
drivers/ieee1394/sbp2.c:1516: conflicting types for `sbp2_handle_physdma_write'
drivers/ieee1394/sbp2.h:513: previous declaration of `sbp2_handle_physdma_write'
drivers/ieee1394/sbp2.c:1532: conflicting types for `sbp2_handle_physdma_read'
drivers/ieee1394/sbp2.h:515: previous declaration of `sbp2_handle_physdma_read'
make[2]: *** [drivers/ieee1394/sbp2.o] Error 1

<--  snip  -->

cu
Adrian

-- 

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
                                Pearl S. Buck - Dragon Seed