Re: [PATCH] fixes for building kernel using Intel compiler

[Andi Kleen]

"Nakajima, Jun" <[e-mail]> writes:

> -asmlinkage int sys_iopl(unsigned long unused)
> +asmlinkage int sys_iopl(struct pt_regs * regs)
>  {
> -       struct pt_regs * regs = (struct pt_regs *) &unused;

The change is wrong. The pt_regs are passed by value on the stack, not by reference.

> 
> -/* Enable FXSR and company _before_ testing for FP problems. */
> -       /*
> -        * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned.
> -        */
> -       if (offsetof(struct task_struct, thread.i387.fxsave) & 15) {
> -               extern void __buggy_fxsr_alignment(void);
> -               __buggy_fxsr_alignment();
> -       }

Why does that not work? IMHO it is legal ISO-C

-Andi