Re: [PATCH] use correct wakeups in fs/pipe.c

[Hanna Linder]

--On Sunday, October 20, 2002 16:49:24 -0700 Davide Libenzi <[e-mail]> wrote:

> On Sun, 20 Oct 2002, Hanna Linder wrote:
> 
>> --On Saturday, October 19, 2002 20:12:42 +0200 Manfred Spraul <[e-mail]> wrote:
>> 
>> > wake_up_interruptible() and _sync() calls are reversed in pipe_read().
>> > 
>> > The attached patches only calls _sync if a schedule() call follows.
>> > 
>> 
>> FYI. This patch fixes a hang on pipetest.c with the --epoll option.
> 
> Hanna, I'm not sure if your port of the epoll pipe code on 2.5.44 is
> correct. That fix shouldn't affect epoll. Try the code I sent you
> yesterday or today, it working fine on my machine without the fix.

You are right. I had changed pipetest.c in all my debugging earlier
and used the original version of pipetest.c with your new patch and
Manfreds, which worked. I will be more carefull in the future.

Thanks.

Hanna