Re: [PATCH] 2.5: ewrk3 cli/sti removal by VDA

[Jeff Garzik]

Adam Kropelin wrote:
> On Mon, Oct 21, 2002 at 08:36:17PM -0400, Jeff Garzik wrote:
> 
>>Adam Kropelin wrote:
>>
>>>Below is a patch from Denis Vlasenko <[e-mail]> 
>>>which
>>>removes cli/sti in the ewrk3 driver. It tests out fine here with SMP & 
>>>preempt.
>>
>>Applied and then cleaned up...  ETHTOOL_PHYS_ID needs to use 
>>schedule_timeout(), and using typeof should be avoided.
> 
> 
> The patch below (against yours) should fix ETHTOOL_PHYS_ID again. Let me
> know if I got it wrong. Was my prior use of
> wait_event_interruptible_tiumeout actually broken or rather
> just a lot more complicated than it needed to be?

broken in 2.4 -and- more complicated than it needed to be in 2.5.x ;-)

> I didn't find any use of typeof. If you point me to it I'll fix that up,
> too.

I fixed it up... grep your original patch.  typeof() was used because 
lp->pktStats was an anonymous structure with no defined typename.  I 
moved the struct out and gave it a name.

> Thanks for bearing with me. I'm climbing the clue-ladder as fast as I
> can... ;)

hehe, thanks for doing the patches and the testing... :)

> --- linux-2.5.44/drivers/net/ewrk3.c	Mon Oct 21 22:01:01 2002
> +++ linux-2.5.44/drivers/net/ewrk3.c.new	Mon Oct 21 21:58:13 2002

quick review says it looks good, I'll make another pass over it with my 
brain switched on, and apply or comment as it warrants :)

	Jeff