Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)

[Osamu Tomita]

Thanks for comments.

Takashi Iwai wrote:
> At Sat, 19 Oct 2002 01:56:53 +0900,
> Osamu Tomita wrote:
> >
> > This is part 23/26 of patchset for add support NEC PC-9800 architecture,
> > against 2.5.43.
> >
> > Summary:
> >  ALSA sound driver related modules.
> >   - add feature to support CS4231+OPL3 (not PNP)
> 
> Are you sure that it's really CS4231?
> If it's a higher model, such as cs4232, cs4235 or cs4236, FM OPL3 is
> already supported (although additional codes to opl3 module are
> necessary for PC9800).
Your comment is reasonable. Some card has CS4232. But CS4232 is used
as CS4231. I guess there is some hardwired circuit. And some card has
CS4231. CS4231 driver works fine for ether chip on PC-9800.
So I choose CS4231 driver for PC-9800.
 
> >   - add hardware specific initialization.
> 
> The MPU401 hack looks odd.
> I'd propose to split a PC9800 specific driver up, rather than
> including bunch of ifdefs...
I see. I'll split MPU401 driver.

Regards
Osamu Tomita