Re: [PATCH] Advanced TCA SCSI/FC disk hotswap driver for kernel 2.5.44

[Greg KH]

On Wed, Oct 23, 2002 at 04:27:06PM -0700, Steven Dake wrote:
> +static ssize_t scsi_hotswap_insert_by_scsi_id_write_file (struct file 
> *file,
> +    const char *buf, size_t count, loff_t *ppos)
> +{
> +    int host, channel, lun, id;
> +    char parameters[1024];

Ouch, don't put 1k on the stack, dynamically allocate it please.

thanks,

greg k-h