[trivial] module.c double init?

Randy.Dunlap (randy.dunlap@verizon.net)
Wed, 23 Oct 2002 20:53:36 -0700


This is a multi-part message in MIME format.
--------------343A2A36B592C87E961DF027
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

in 2.5.44: kernel/module.c, function s_start(), there is:
loff_t n = *pos;

and then same "n = *pos" is done in the for-loop initializer.
It's just a thinko, right? or am I missing something?

Patch attached (to 2.5.44).

~Randy
--------------343A2A36B592C87E961DF027
Content-Type: text/plain; charset=us-ascii;
name="module-dblinit-2544.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="module-dblinit-2544.patch"

--- ./kernel/module.c.fixit Fri Oct 18 21:01:17 2002
+++ ./kernel/module.c Wed Oct 23 19:54:10 2002
@@ -1165,7 +1165,7 @@
if (!p)
return ERR_PTR(-ENOMEM);
lock_kernel();
- for (v = module_list, n = *pos; v; n -= v->nsyms, v = v->next) {
+ for (v = module_list; v; n -= v->nsyms, v = v->next) {
if (n < v->nsyms) {
p->mod = v;
p->index = n;

--------------343A2A36B592C87E961DF027--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/