Re: [PATCH] hyper-threading information in /proc/cpuinfo

[Jeff Garzik]

Dave Jones wrote:

>On Fri, Oct 25, 2002 at 05:30:19PM -0400, Robert Love wrote:
>
> > +#ifdef CONFIG_SMP
> > +	if (cpu_has_ht) {
> > +		seq_printf(m, "physical processor ID\t: %d\n", phys_proc_id[n]);
> > +		seq_printf(m, "number of siblings\t: %d\n", smp_num_siblings);
> > +	}
> > +#endif
>
>Something else looks suspect to me here.
>smp_num_siblings is going to say the same value on every CPU in the
>system. It's questionable whether we want to print it out n times.
>  
>

Not really... we print out other information that is duplicated N times, 
because it is the common case that N-way systems have matched processors 
with matched capabilities.  The above caught my eye as well, but the 
alternative is to subvert the standard /proc/cpuinfo format and print 
something out only once, that clearly applies to each processor.

    Jeff