Re: [PATCH] NCR53C9x ESP: C99 designated initializers

[Geert Uytterhoeven]

On 10 Nov 2002, Alan Cox wrote:
> On Sun, 2002-11-10 at 10:27, Geert Uytterhoeven wrote:
> ut soft reset.
> >   */
> > -int esp_reset(Scsi_Cmnd *SCptr, unsigned int how)
> > +int esp_reset(Scsi_Cmnd *SCptr)
> >  {
> >  	struct NCR_ESP *esp = (struct NCR_ESP *) SCptr->host->hostdata;
> >  
> >  	(void) esp_do_resetbus(esp, esp->eregs);
> > -	return SCSI_RESET_PENDING;
> > +	wait_event(esp->reset_queue, (esp->resetting_bus == 0));
> > +
> > +	return SUCCESS;
> >  }
> 
> Reset is called with the lock held surely. How can the wait_event be
> right ? 

I don't know. I just ported the Sun/SPARC ESP SCSI driver changes in 2.5.45 to
the NCR53C9x ESP SCSI drivers. If you're right, the same bug is present in
esp.c.

Dave?

BTW, what about merging esp.c and NCR53C9x.c?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds