Re: PATCH 2.4: scsi and BLK_STATS

Christoph Hellwig (hch@infradead.org)
Wed, 13 Nov 2002 00:15:30 +0000


On Tue, Nov 12, 2002 at 06:28:21PM +0100, Matthias Urlichs wrote:
> Some people might want SCSI without block statistics...

Probably. But your patch doesn;t gain them anything but a useless
ifdef.. Look at include/linux/genhd.h:

#ifdef CONFIG_BLK_STATS
extern void disk_round_stats(struct hd_struct *hd);
extern void req_new_io(struct request *req, int merge, int sectors);
extern void req_merged_io(struct request *req);
extern void req_finished_io(struct request *req);
#else
static inline void req_new_io(struct request *req, int merge, int sectors) { }
static inline void req_merged_io(struct request *req) { }
static inline void req_finished_io(struct request *req) { }
#endif /* CONFIG_BLK_STATS */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/