Re: [2.5-bk] Module loader compile bug

Brad Heilbrun (bheilbrun@paypal.com)
Tue, 12 Nov 2002 18:13:07 -0800


On Wed, Nov 13, 2002 at 04:23:26AM +1100, Rusty Russell wrote:
> In message <20021112050319.GA3651@paypal.com> you write:
> > I realize you're still working on this, but current bk is broken if
> > you turn off module unload support. In include/linux/module.h we get:
> >
> > #else /*!CONFIG_MODULE_UNLOAD*/
> > <snip>
> > #define symbol_put_addr(p) do { } while(0)
> >
> > #endif /* CONFIG_MODULE_UNLOAD */
> >
> > Which upsets this line in kernel/module.c
> >
> > void symbol_put_addr(void *addr)
> >
> > After the preprocessor gets a hold of it all, gcc doesn't know what to
> > make of "void do { } while(0)".
>
> Yep, symbol_put_addr() in module.c should be moved under __symbol_put.
>
> Patch is fairly trivial, does this work for you?

Yes, thanks.

-- 
Brad Heilbrun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/