Re: Kill obsolete and unused suspend/resume code from IDE

Alan Cox (alan@lxorguk.ukuu.org.uk)
13 Nov 2002 14:50:35 +0000


On Wed, 2002-11-13 at 14:13, Pavel Machek wrote:
> I noticed you are not playing any tricks with inserting requests to
> queues... This is basically what I was doing, so I like it.
>
> Is sc1200_spindown_drive really sc1200 specific? Is there some problem
> with doing suspend at ide.c layer, and resume (which is controller
> specific) in each driver?
>
> ...Ugh. You are doing it as pci device, not as generic device. I
> believe you should use sysfs directly.
>
> Anyway I can live with this, and its way better than whats in there
> just now.

If you think doing it in sysfs is the right way, then move it to sysfs.
The drive spindown is going to end up on the end of the comamnd queue
anyway. Right now we don't have any controller specific power
management, but for some controllers there is power management that we
can do when sleeping (pci D3, turning off buffers etc)

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/