Re: [PATCH] early printk for x86

Andi Kleen (ak@suse.de)
Fri, 15 Nov 2002 04:43:00 +0100


On Thu, Nov 14, 2002 at 02:50:43PM -0800, Dave Hansen wrote:
> Jeff Garzik wrote:
> >VGA and serial are certainly not hammer+ia32-specific. Make the generic
> >parts generic... the arch-specific components would need to change
> >early-foo base addresses perhaps, but otherwise, it's pretty generic.
>
> Take 2.
>
> - Move the x86_64 early_printk.c into kernel/
> - move some of the basic defines into linux/early_printk.h and
> asm-{i386,x86_64}/early_printk.h
> - run the setup in start_kernel() before setup_arch()

That's overkill. Most architectures have an early_printk equivalent in
firmware. Only i386 and x86-64 are not lucky enough to have one
that is usable from the CPU mode linux uses.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/