Re: [RFC][PATCH] move dma_mask into struct device

Arnd Bergmann (arndb@de.ibm.com)
Sat, 16 Nov 2002 18:23:48 +0100


J.E.J. Bottomley [James.Bottomley@steeleye.com] wrote:

> Attached is a patch which moves dma_mask into struct device and cleans up the
> scsi mid-layer to use it (instead of using struct pci_dev). The advantage to
> doing this is probably most apparent on non-pci bus architectures where
> currently you have to construct a fake pci_dev just so you can get the bounce
> buffers to work correctly.

That does not sound like the right way to me. If you need to have the dma_mask
for the Scsi_Host, you should store it in Scsi_Host itself. A struct device
must never know about obscure architecture specific stuff like dma.

Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/