Re: Patch/resubmit(2.5.49): Use struct io_restrictions in blkdev.h

[Adam J. Richter]

Christoph Hellwig wrote:
>On Wed, Nov 27, 2002 at 12:59:46PM -0800, Adam J. Richter wrote:
>> >On Wed, Nov 27, 2002 at 11:49:40AM -0800, Adam J. Richter wrote:
>> >> 	Here is an updated version of the patch.  The struct
>> >> io_restrictions declaration is in <linux/device-mapper.h> so that the
>> >> device-mapper user level utilities compile properly (device-mapper.h
>> >> is written to support inclusion by user level programs).
>> 
>> >They shouldn't include it anyway.  Please put it into a proper place.
>> 
>> 	I don't know what you mean by "shouldn't" or "proper" in this
>> context.  If you'd state technical advantages or disadvanges, others
>> could determine these labels for themselves.
>> 
>> 	Anyhow, what would be a "proper" place as you see it?

>blkdev.h

	I expect struct io_restrictions to be useful beyond blkdev.  I
want to evolve it for use in DMA scatterlists in general, so blkdev.h
could only be a temporary home.  If you really want and nobody else
objects, I'd be willing to create a separate .h file for struct
io_restrictions.  (I assume that what you find "improper" about
device-mapper.h is that block devices themselves do not depend
on any abstractions specific to the device mapper.)

	That would not break device-mapper, and you could take the
less disruptive approach of submitting a patch to glibc and/or
device-mapper to eliminate the user level program including kernel
headers.

Adam J. Richter     __     ______________   575 Oroville Road
[e-mail]     \ /                  Milpitas, California 95035
[phone]         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."